Skip to content

[BUGFIX] Improve accuracy and performance of condition in ConfigureSite.php

Insidious Fiddler requested to merge Fix-duplicate-entry-for-settings into main

This pull request addresses a bug in the ConfigureSite.php file, specifically related to the condition check for the existence of a setting. The fix replaces the usage of Setting::get() with Setting::where('key', '...')->count() to improve performance and accuracy.

By using Setting::where('key', '...')->count(), the condition check now directly examines the database for the count of rows with a matching key, offering a more precise and efficient approach.

Merge request reports

Loading